birdulon
/
GuitarModels
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Anoher attempt, add a small notch to cylindrical holes to attempt to move seams out of the way

This commit is contained in:
Luke Hubmayer-Werner 2025-01-11 14:35:19 +10:30
parent b0efa30421
commit 491b0d4d63
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CFTubes.scad
View File

@ -73,6 +73,9 @@ module neck(string_spacing=18, string_margin=4.5, num_strings=3, target_neck_thi
translate([-500, fret_scale_length(fret)-fret_width/2, -500]) translate([-500, fret_scale_length(fret)-fret_width/2, -500])
cube([1000, fret_width, 1000]); cube([1000, fret_width, 1000]);
} }
// Some precision error with fret 0 :/
translate([-500, fret_scale_length(0)-fret_width/2+0.0006, -500])
cube([1000, fret_width, 1000]);
} }
module fret_inlays() { module fret_inlays() {
for (num_text = fret_inlays) { for (num_text = fret_inlays) {
@ -388,7 +391,7 @@ module Nylon6String(render_colour_0=true, render_colour_1=true, render_colour_2=
colour_2 = "green"; // side markers colour_2 = "green"; // side markers
colour_3 = "yellow"; // inlays colour_3 = "yellow"; // inlays
id_line_0 = "PLA"; id_line_0 = "PLA";
id_line_1 = "1γ"; id_line_1 = "1δ";
fsl_mm = fret_scale_length(0); fsl_mm = fret_scale_length(0);
string_diameters_thous = [28, 32, 40, 30, 36, 42]; string_diameters_thous = [28, 32, 40, 30, 36, 42];
@ -527,7 +530,7 @@ module Nylon6String(render_colour_0=true, render_colour_1=true, render_colour_2=
RealPiece(from_fret, to_fret, include_from_fret = (from_fret==0)); RealPiece(from_fret, to_fret, include_from_fret = (from_fret==0));
// RealPiece(0, 8, include_from_fret=true); // RealPiece(0, 8, include_from_fret=true);
// RealPiece(8, 21); // RealPiece(8, 21);
%translate([100, 0, 0]) RealPiece(8, 21); // %translate([100, 0, 0]) RealPiece(8, 21);
if ($preview) { if ($preview) {
translate([-100,0,0]) union() { translate([-100,0,0]) union() {

7
CFTubes/common.scad
View File

@ -74,7 +74,7 @@ module CFSquareCutout(x1, x2, tolerance = CF_Square_Width_tolerance, taper_x1 =
} }
} }
module CFTubeCutout2(v, block_y0, block_y1, tolerance = CF_Tube_OD_tolerance, VLH = false, taper_length = 2, taper_mul = 1.1) { module CFTubeCutout2(v, block_y0, block_y1, tolerance = CF_Tube_OD_tolerance, VLH = false, taper_length = 2, taper_mul = 1.1, notch = true) {
// Alternate approach: supply start vector v, and the bounding y values of the piece, taper on entry points only. // Alternate approach: supply start vector v, and the bounding y values of the piece, taper on entry points only.
tolerance = tolerance + (VLH ? 0.3 : 0); tolerance = tolerance + (VLH ? 0.3 : 0);
tube_y0 = v[1]; tube_y0 = v[1];
@ -84,8 +84,11 @@ module CFTubeCutout2(v, block_y0, block_y1, tolerance = CF_Tube_OD_tolerance, VL
fn = 360; fn = 360;
// Full cylinder, unconditional // Full cylinder, unconditional
translate(v) translate(v) hull() {
rotate([-90,0,0]) cylinder(h=CF_Tube_Len, d=OD, $fn=fn); rotate([-90,0,0]) cylinder(h=CF_Tube_Len, d=OD, $fn=fn);
if (notch) translate([-OD*0.02, 0, -OD*0.6]) cube([OD*0.04, CF_Tube_Len, OD*0.6]);
}
// Check for tapered holes // Check for tapered holes
if ((block_y0 >= tube_y0) && (block_y0 < tube_y1)) // Tube protrudes through start of block if ((block_y0 >= tube_y0) && (block_y0 < tube_y1)) // Tube protrudes through start of block
hull() { hull() {