From f176c9576c7892276b2d0a6fa2001d93323b5c32 Mon Sep 17 00:00:00 2001 From: Luke Hubmayer-Werner Date: Tue, 2 Apr 2024 16:06:13 +1030 Subject: [PATCH] Experimenting with optimizations --- T-riple.scad | 52 +++++++++++++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/T-riple.scad b/T-riple.scad index 7003de4..8f64ae1 100644 --- a/T-riple.scad +++ b/T-riple.scad @@ -2,12 +2,10 @@ include include semitone_strings = ["0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "X", "XI"]; -octave_strings = ["", "˙", "¨", "¯"]; +octave_strings = ["", ".", "..", "_"]; octave_scales = [1.1, 1, 0.9, 0.8]; z_resolution = $preview ? 0.5 : 0.1; -$fs = $preview ? 1 : 0.01; -$fa = $preview ? 5 : 0.1; profile_arc_steps_backside = $preview ? 8 : 360; profile_arc_steps_topside = $preview ? 8 : 60; @@ -93,15 +91,25 @@ module tube(from_fret, to_fret, scale_offset = 0, fingerboard_min_thick = 2.5, f o = fret_width/2 * sin(fret_angle), x0 = f_prev - o, x1 = f_next + o, + x_mid = (x0+x1)/2, y0 = fingerboard_min_thick, y1 = fingerboard_max_thick - (fret_width/2 * cos(fret_angle)), - pts = [[x0, y1], [x1, y1], [(x0+x1)/2, y0]], + pts = [[x0, y1], [x1, y1], [x_mid, y0]], cc = tri_circumcenter(pts), - r = norm([x0, y1] - cc) + r = norm([x0, y1] - cc), + r2 = r^2, + a_start = acos((x0 - cc[0])/r), + a_end = acos((x1 - cc[0])/r), + a_sweep = a_end - a_start, + a_step = a_sweep/10 ) { - translate([0,-w/2,0]) - rotate([-90,-90,0]) - translate(cc) cylinder(h = w, r = r, $fn=max(8*ceil(r), 32)); + // echo(a_start=a_start, x0=x0, cc=cc); + translate([cc[1], 0, cc[0]]) + rotate([90,0,0]) + // cylinder(h = w, r = r, center = true); + linear_extrude(height = w, center = true) + // polygon([for (i = [0:10]) [-r*sin(a_start+i*a_step), r*cos(a_start+i*a_step)]]); + polygon([for (x = [x1-x_mid:0.05:x0-x_mid]) [-sqrt(r2 - x^2), x]]); } } @@ -129,26 +137,28 @@ module tube(from_fret, to_fret, scale_offset = 0, fingerboard_min_thick = 2.5, f // color("red") scallops(); } + module fret_number_text(fret) { + octave = floor(fret/12); + semitone = fret%12; + octave_scale = octave_scales[octave]; + text(semitone_strings[semitone], size=4*octave_scale, halign="center", valign="center", font="Noto Sans", $fa=1, $fs=0.1); + translate([0, 2.5]) + text(octave_strings[octave], size=5*octave_scale, halign="center", valign="center", font="Noto Sans", $fa=1, $fs=0.1); + } + module fret_number_markers(engrave_depth=1) { color("purple") // for (fret = [from_fret:to_fret]) for (fret = [from_fret+1:to_fret]) { zn = fsl(fret); pr = get_desired_profile_radius(get_desired_width_scale(zn)); - octave = floor(fret/12); - semitone = fret%12; - octave_scale = octave_scales[octave]; - // translate([-3,-16,zn-z_offset]) rotate([90,25,16]) linear_extrude(100) { - // translate([-3,-16,zn-z_offset]) rotate([90,25,-16+16*(zn/z0)]) linear_extrude(100) { p_x0 = pr+x_min; - translate([p_x0, 0, zn-z_offset]) rotate([90,25,-asin((p_x0+2)/pr)]) translate([0, 0, pr-engrave_depth]) linear_extrude(engrave_depth+1) { - text(semitone_strings[semitone], size=4*octave_scale, halign="center", valign="center", font="Noto Sans"); - text(octave_strings[octave], size=6*octave_scale, halign="center", valign="center", font="Noto Sans"); - } - translate([p_x0, 0, zn-z_offset]) rotate([90,-25,180+asin((p_x0+2)/pr)]) translate([0, 0, pr-engrave_depth]) linear_extrude(engrave_depth+1) { - text(semitone_strings[semitone], size=4*octave_scale, halign="center", valign="center", font="Noto Sans"); - text(octave_strings[octave], size=6*octave_scale, halign="center", valign="center", font="Noto Sans"); - } + translate([p_x0, 0, zn-z_offset]) rotate([90,25,-asin((p_x0+2)/pr)]) + translate([0, 0, pr-engrave_depth]) linear_extrude(engrave_depth+1) + fret_number_text(fret); + translate([p_x0, 0, zn-z_offset]) rotate([90,-25,180+asin((p_x0+2)/pr)]) + translate([0, 0, pr-engrave_depth]) linear_extrude(engrave_depth+1) + fret_number_text(fret); } }